Re: [libvirt] [PATCH] virt-admin: Properly fix the default session daemon URI to admin server

2016-08-09 Thread Erik Skultety
On 09/08/16 16:04, Jiri Denemark wrote: > On Tue, Aug 09, 2016 at 15:43:57 +0200, Erik Skultety wrote: >> Commit 30ce2f0e tried to fix the issue with an incorrect session URI to admin >> server but it messed up the checks: >> >> if (geteuid == 0 && VIR_STRDUP(*uristr, "libvirtd:///system") < 0)

Re: [libvirt] [PATCH] virt-admin: Properly fix the default session daemon URI to admin server

2016-08-09 Thread Jiri Denemark
On Tue, Aug 09, 2016 at 15:43:57 +0200, Erik Skultety wrote: > Commit 30ce2f0e tried to fix the issue with an incorrect session URI to admin > server but it messed up the checks: > > if (geteuid == 0 && VIR_STRDUP(*uristr, "libvirtd:///system") < 0) > return -1; > else if (VIR_STRD

[libvirt] [PATCH] virt-admin: Properly fix the default session daemon URI to admin server

2016-08-09 Thread Erik Skultety
Commit 30ce2f0e tried to fix the issue with an incorrect session URI to admin server but it messed up the checks: if (geteuid == 0 && VIR_STRDUP(*uristr, "libvirtd:///system") < 0) return -1; else if (VIR_STRDUP(*uristr, "libvirtd:///session") < 0) return -1; So if a clien