Re: [libvirt] [PATCH] vmware: make version parsing more robust

2014-06-11 Thread Ján Tomko
On 06/09/2014 10:12 AM, Jean-Baptiste Rouault wrote: > On Monday 28 April 2014 13:46:54 Ján Tomko wrote: >> On 04/09/2014 11:59 AM, Jean-Baptiste Rouault wrote: >>> Since commit d69415d4, vmware version is parsed from both stdout and >>> stderr. This patch makes version parsing work even if there i

Re: [libvirt] [PATCH] vmware: make version parsing more robust

2014-06-09 Thread Jean-Baptiste Rouault
On Monday 28 April 2014 13:46:54 Ján Tomko wrote: > On 04/09/2014 11:59 AM, Jean-Baptiste Rouault wrote: > > Since commit d69415d4, vmware version is parsed from both stdout and > > stderr. This patch makes version parsing work even if there is garbage > > (libvirt debug messages for example) in th

Re: [libvirt] [PATCH] vmware: make version parsing more robust

2014-04-28 Thread Ján Tomko
On 04/09/2014 11:59 AM, Jean-Baptiste Rouault wrote: > Since commit d69415d4, vmware version is parsed from both stdout and > stderr. This patch makes version parsing work even if there is garbage > (libvirt debug messages for example) in the command output. For libvirt's debug messages, we have v

[libvirt] [PATCH] vmware: make version parsing more robust

2014-04-09 Thread Jean-Baptiste Rouault
Since commit d69415d4, vmware version is parsed from both stdout and stderr. This patch makes version parsing work even if there is garbage (libvirt debug messages for example) in the command output. Add test data for this case. --- src/vmware/vmware_conf.c | 10