Re: [libvirt] [PATCH] vsh: Fix warnings in command line completer

2016-10-06 Thread Erik Skultety
On 06/10/16 09:57, Michal Privoznik wrote: > On 05.10.2016 09:26, Jiri Denemark wrote: >> GCC complained that >> >> vsh.c: In function 'vshReadlineOptionsGenerator': >> vsh.c:2622:29: warning: unused variable 'opt' [-Wunused-variable] >> const vshCmdOptDef *opt = &cmd->opts[list_index]; >>

Re: [libvirt] [PATCH] vsh: Fix warnings in command line completer

2016-10-06 Thread Michal Privoznik
On 05.10.2016 09:26, Jiri Denemark wrote: > GCC complained that > > vsh.c: In function 'vshReadlineOptionsGenerator': > vsh.c:2622:29: warning: unused variable 'opt' [-Wunused-variable] > const vshCmdOptDef *opt = &cmd->opts[list_index]; > ^ > vsh.c: In functi

Re: [libvirt] [PATCH] vsh: Fix warnings in command line completer

2016-10-05 Thread Jiri Denemark
On Wed, Oct 05, 2016 at 16:07:09 +0200, Martin Kletzander wrote: > On Wed, Oct 05, 2016 at 09:26:43AM +0200, Jiri Denemark wrote: > >@@ -2648,7 +2647,7 @@ vshReadlineParse(const char *text, int state) > > static vshCommandParser parser, sanitizer; > > vshCommandToken tk; > > static cons

Re: [libvirt] [PATCH] vsh: Fix warnings in command line completer

2016-10-05 Thread Martin Kletzander
On Wed, Oct 05, 2016 at 09:26:43AM +0200, Jiri Denemark wrote: GCC complained that vsh.c: In function 'vshReadlineOptionsGenerator': vsh.c:2622:29: warning: unused variable 'opt' [-Wunused-variable] const vshCmdOptDef *opt = &cmd->opts[list_index]; ^ vsh.c: In

[libvirt] [PATCH] vsh: Fix warnings in command line completer

2016-10-05 Thread Jiri Denemark
GCC complained that vsh.c: In function 'vshReadlineOptionsGenerator': vsh.c:2622:29: warning: unused variable 'opt' [-Wunused-variable] const vshCmdOptDef *opt = &cmd->opts[list_index]; ^ vsh.c: In function 'vshReadlineParse': vsh.c:2830:44: warning: 'opt' may