Re: [libvirt] [PATCH] vz: build fix for virStorageBackendVzPoolStart

2019-03-18 Thread Andrea Bolognani
On Mon, 2019-03-18 at 07:27 +, Nikolay Shirokovskiy wrote: > On 15.03.2019 23:02, Eric Blake wrote: > > I'm trying to get a working build of src/vz/ on my system, to make sure > > I don't cause similar types of build-breakage. What is the process for > > getting PARALLELS_SDK installed on Fedo

Re: [libvirt] [PATCH] vz: build fix for virStorageBackendVzPoolStart

2019-03-18 Thread Eric Blake
On 3/18/19 2:27 AM, Nikolay Shirokovskiy wrote: >> I'm trying to get a working build of src/vz/ on my system, to make sure >> I don't cause similar types of build-breakage. What is the process for >> getting PARALLELS_SDK installed on Fedora 29? > > Hi, Erik! > > We don't test our package buil

[libvirt] [PATCH] vz: build fix for virdomainsnapshotobjlist.h

2019-03-18 Thread Nikolay Shirokovskiy
Commit [1] moved snapshot list functions declaration into its own file but missed a fix for vz driver. [1] 9b75154c : snapshot: Break out virDomainSnapshotObjList into its own file Signed-off-by: Nikolay Shirokovskiy --- Pushed as trivial/build fix. src/vz/vz_utils.h | 1 + 1 file changed, 1

Re: [libvirt] [PATCH] vz: build fix for virStorageBackendVzPoolStart

2019-03-18 Thread Nikolay Shirokovskiy
On 15.03.2019 23:02, Eric Blake wrote: > On 2/19/19 3:57 AM, Nikolay Shirokovskiy wrote: >> Remove unused variable. Fix for [1] >> >> [1] 821dd6d8: storage: Use VIR_AUTOFREE for storage backends >> >> Signed-off-by: Nikolay Shirokovskiy >> --- >> >> Pushed as trivial build fix. > > I'm trying t

Re: [libvirt] [PATCH] vz: build fix for virStorageBackendVzPoolStart

2019-03-15 Thread Eric Blake
On 2/19/19 3:57 AM, Nikolay Shirokovskiy wrote: > Remove unused variable. Fix for [1] > > [1] 821dd6d8: storage: Use VIR_AUTOFREE for storage backends > > Signed-off-by: Nikolay Shirokovskiy > --- > > Pushed as trivial build fix. I'm trying to get a working build of src/vz/ on my system, to ma

[libvirt] [PATCH] vz: build fix for virStorageBackendVzPoolStart

2019-02-22 Thread Nikolay Shirokovskiy
Remove unused variable. Fix for [1] [1] 821dd6d8: storage: Use VIR_AUTOFREE for storage backends Signed-off-by: Nikolay Shirokovskiy --- Pushed as trivial build fix. src/storage/storage_backend_vstorage.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/storage/storage_backend_vstorage.

Re: [libvirt] [PATCH] vz: build fix

2018-04-18 Thread Nikolay Shirokovskiy
On 18.04.2018 17:03, Daniel P. Berrangé wrote: > On Wed, Apr 18, 2018 at 04:45:31PM +0300, Nikolay Shirokovskiy wrote: >> Broken by [1] commit - trailing comma instead of semicolon. Fortunately >> the issue did not get sneak in released 4.2 version. Note that uriSchemes >> for parallelsConnectDri

Re: [libvirt] [PATCH] vz: build fix

2018-04-18 Thread Daniel P . Berrangé
On Wed, Apr 18, 2018 at 04:45:31PM +0300, Nikolay Shirokovskiy wrote: > Broken by [1] commit - trailing comma instead of semicolon. Fortunately > the issue did not get sneak in released 4.2 version. Note that uriSchemes > for parallelsConnectDriver should not be allocated on stack. > > [1] 8e4f9a2

[libvirt] [PATCH] vz: build fix

2018-04-18 Thread Nikolay Shirokovskiy
Broken by [1] commit - trailing comma instead of semicolon. Fortunately the issue did not get sneak in released 4.2 version. Note that uriSchemes for parallelsConnectDriver should not be allocated on stack. [1] 8e4f9a27: "driver: declare supported URI schemes in virConnectDriver struct" --- src/v

Re: [libvirt] [PATCH] vz: build fix

2017-08-24 Thread Erik Skultety
On Thu, Aug 24, 2017 at 10:08:35AM +0300, Nikolay Shirokovskiy wrote: > 6e6faf6d changed vzDomObjAlloc signature in source but not in header file. > --- > src/vz/vz_utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h > index ea2e2d

[libvirt] [PATCH] vz: build fix

2017-08-24 Thread Nikolay Shirokovskiy
6e6faf6d changed vzDomObjAlloc signature in source but not in header file. --- src/vz/vz_utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vz/vz_utils.h b/src/vz/vz_utils.h index ea2e2da..d213183 100644 --- a/src/vz/vz_utils.h +++ b/src/vz/vz_utils.h @@ -116,7 +116,7