Re: [libvirt] [PATCH] xen_xs: Guard against set but empty kernel argument

2011-10-10 Thread Guido Günther
On Mon, Oct 10, 2011 at 01:24:35PM -0600, Eric Blake wrote: > On 10/10/2011 09:14 AM, Guido Guenther wrote: > >On xen 4.1 I observied configurations that look like: > > s/observied/observed/ > > > > >(image > > (hvm > > (kernel '') > > (loader '/foo/bar') > >)) > > > >The kern

Re: [libvirt] [PATCH] xen_xs: Guard against set but empty kernel argument

2011-10-10 Thread Eric Blake
On 10/10/2011 09:14 AM, Guido Guenther wrote: On xen 4.1 I observied configurations that look like: s/observied/observed/ (image (hvm (kernel '') (loader '/foo/bar') )) The kernel element is there but unset. This leads to an emtpy element in the XML and even worse mak

[libvirt] [PATCH] xen_xs: Guard against set but empty kernel argument

2011-10-10 Thread Guido Guenther
On xen 4.1 I observied configurations that look like: (image (hvm (kernel '') (loader '/foo/bar') )) The kernel element is there but unset. This leads to an emtpy element in the XML and even worse makes us skip the boot order parsing and therefore not emit a element which br