Re: [libvirt] [PATCH] xend_internal: don't let invalid input provoke NULL dereference

2010-01-06 Thread Jim Meyering
Daniel Veillard wrote: >> Subject: [PATCH] xend_internal: don't let invalid input provoke NULL >> dereference >> * src/xen/xend_internal.c (xenDaemonOpen_unix): Do not dereference >> a NULL "conn". Move first deref to follow the "conn == NULL" test. > > ACK, clearly an oversight, thanks ! Than

Re: [libvirt] [PATCH] xend_internal: don't let invalid input provoke NULL dereference

2010-01-06 Thread Daniel Veillard
On Wed, Jan 06, 2010 at 01:02:01PM +0100, Jim Meyering wrote: > If there's a good reason to test for NULL "conn", then > we certainly must not dereference "conn" before that point. > > This assumes we do want to retain the NULL test. > Note that many other functions perform this same test. > > >F

[libvirt] [PATCH] xend_internal: don't let invalid input provoke NULL dereference

2010-01-06 Thread Jim Meyering
If there's a good reason to test for NULL "conn", then we certainly must not dereference "conn" before that point. This assumes we do want to retain the NULL test. Note that many other functions perform this same test. >From 2c7b628728efcb5a59c1e7aa1cba763f5ef0045a Mon Sep 17 00:00:00 2001 From: