Re: [libvirt] [PATCH 0/2] Add unit tests for internal CPU APIs

2010-12-01 Thread Jiri Denemark
ACK series, but should tests/cputest.c be given a copyright notice? Also, make sure 'make syntax-check' passes; I noticed a failure on sc_prohibit_empty_lines_at_EOF on tests/sputestdata/x86-nehalem-force.xml. I fixed both issues (and one possible NULL-pointer dereference in an error path) and

Re: [libvirt] [PATCH 0/2] Add unit tests for internal CPU APIs

2010-11-30 Thread Jiri Denemark
*** BLURB HERE *** Ignoring git's hint to add an overview, are we? :) Not really ignoring, just not noticing and forgetting :-) Jiri Denemark (2): cpu: Add support for overriding path to CPU map XML file tests: Add unit tests for internal CPU APIs ACK series, but should

Re: [libvirt] [PATCH 0/2] Add unit tests for internal CPU APIs

2010-11-30 Thread Eric Blake
On 11/30/2010 03:09 AM, Jiri Denemark wrote: *** BLURB HERE *** Ignoring git's hint to add an overview, are we? :) Not really ignoring, just not noticing and forgetting :-) Jiri Denemark (2): cpu: Add support for overriding path to CPU map XML file tests: Add unit tests for internal

Re: [libvirt] [PATCH 0/2] Add unit tests for internal CPU APIs

2010-11-29 Thread Eric Blake
On 11/25/2010 10:24 AM, Jiri Denemark wrote: *** BLURB HERE *** Ignoring git's hint to add an overview, are we? :) Jiri Denemark (2): cpu: Add support for overriding path to CPU map XML file tests: Add unit tests for internal CPU APIs ACK series, but should tests/cputest.c be given a

[libvirt] [PATCH 0/2] Add unit tests for internal CPU APIs

2010-11-25 Thread Jiri Denemark
*** BLURB HERE *** Jiri Denemark (2): cpu: Add support for overriding path to CPU map XML file tests: Add unit tests for internal CPU APIs src/cpu/cpu_map.c | 21 +- src/cpu/cpu_map.h |3 + src/libvirt_private.syms