Re: [libvirt] [PATCH 0/2] VIR_STRDUP ease of use

2013-05-07 Thread Eric Blake
On 05/07/2013 03:37 AM, Michal Privoznik wrote: > On 07.05.2013 05:24, Eric Blake wrote: >> As pointed out during my (ongoing) review of Michal's series, I >> think that letting VIR_STRDUP take a NULL source can make it >> easier to use; I also think that documenting the guarantee that >> it evalua

Re: [libvirt] [PATCH 0/2] VIR_STRDUP ease of use

2013-05-07 Thread Michal Privoznik
On 07.05.2013 05:24, Eric Blake wrote: > As pointed out during my (ongoing) review of Michal's series, I > think that letting VIR_STRDUP take a NULL source can make it > easier to use; I also think that documenting the guarantee that > it evaluates arguments exactly once is worth enforcing. > > Hm

[libvirt] [PATCH 0/2] VIR_STRDUP ease of use

2013-05-06 Thread Eric Blake
As pointed out during my (ongoing) review of Michal's series, I think that letting VIR_STRDUP take a NULL source can make it easier to use; I also think that documenting the guarantee that it evaluates arguments exactly once is worth enforcing. Hmm, I guess that means I should write a 3/2 patch th