Re: [libvirt] [PATCH 0/4] test_driver: implement virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML

2019-06-04 Thread Erik Skultety
On Mon, Jun 03, 2019 at 08:27:29PM +0200, Ilias Stamatis wrote: > On Mon, Jun 3, 2019 at 1:50 PM Pavel Hrdina wrote: > > > > On Mon, Jun 03, 2019 at 10:36:58AM +0200, Erik Skultety wrote: > > > On Wed, May 29, 2019 at 02:22:55PM +0200, Ilias Stamatis wrote: > > > > While implementing

Re: [libvirt] [PATCH 0/4] test_driver: implement virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML

2019-06-03 Thread Ilias Stamatis
On Mon, Jun 3, 2019 at 1:50 PM Pavel Hrdina wrote: > > On Mon, Jun 03, 2019 at 10:36:58AM +0200, Erik Skultety wrote: > > On Wed, May 29, 2019 at 02:22:55PM +0200, Ilias Stamatis wrote: > > > While implementing virDomainSaveImageGetXMLDesc and > > > virDomainSaveImageDefineXML for the test

Re: [libvirt] [PATCH 0/4] test_driver: implement virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML

2019-06-03 Thread Pavel Hrdina
On Mon, Jun 03, 2019 at 10:36:58AM +0200, Erik Skultety wrote: > On Wed, May 29, 2019 at 02:22:55PM +0200, Ilias Stamatis wrote: > > While implementing virDomainSaveImageGetXMLDesc and > > virDomainSaveImageDefineXML for the test driver, I realized that there > > exists already code for saving and

Re: [libvirt] [PATCH 0/4] test_driver: implement virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML

2019-06-03 Thread Erik Skultety
On Wed, May 29, 2019 at 02:22:55PM +0200, Ilias Stamatis wrote: > While implementing virDomainSaveImageGetXMLDesc and > virDomainSaveImageDefineXML for the test driver, I realized that there > exists already code for saving and loading test images which can be > reused. However, it needed to be

[libvirt] [PATCH 0/4] test_driver: implement virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML

2019-05-29 Thread Ilias Stamatis
While implementing virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML for the test driver, I realized that there exists already code for saving and loading test images which can be reused. However, it needed to be extracted from testDomainSaveFlags and testDomainRestoreFlags into