During my checkpoint series, one of the review comments complained
that setting the <creationTime> element during XML parsing to the
current time is non-deterministic, which in turn makes writing
testsuite additions difficult. The recommendation was to split out the
non-deterministic defaults to a post-parse handler. Of course, since
checkpoints copied from snapshots, I first need to fix snapshots to do
the same, hence this series.

Eric Blake (5):
  snapshot: Refactor snapshotxml2xml test
  snapshot: Don't expose testsuite-only state in snapshot XML
  snapshot: Factor out post-parse code
  snapshot: Allow for post-parse override
  snapshot: Use post-parse instead of regex in testsuite

 src/conf/domain_conf.h                        |   9 +
 src/conf/moment_conf.h                        |   2 +
 docs/schemas/domainsnapshot.rng               |   1 -
 src/conf/domain_conf.c                        |  24 +++
 src/conf/moment_conf.c                        |  19 ++
 src/conf/snapshot_conf.c                      |  22 +--
 src/libvirt_private.syms                      |   1 +
 .../disk_driver_name_null.xml                 |   1 +
 .../disk_snapshot.xml                         |   1 +
 tests/domainsnapshotxml2xmlout/empty.xml      |   1 -
 .../domainsnapshotxml2xmlout/external_vm.xml  |   1 +
 .../name_and_description.xml                  |   1 -
 tests/domainsnapshotxml2xmlout/noparent.xml   |   2 +-
 tests/domainsnapshotxml2xmltest.c             | 170 +++++++-----------
 14 files changed, 137 insertions(+), 118 deletions(-)

-- 
2.20.1

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Reply via email to