Re: [libvirt] [PATCH 0/7] Address some Coverity found issues

2015-07-03 Thread John Ferlan
On 07/02/2015 05:30 AM, Michal Privoznik wrote: > On 01.07.2015 16:03, John Ferlan wrote: >> > > I'm picking a random Coverity thread to express my latest thoughts on > this. I'm not trying to say the problems I'm raising are necessarily > introduced here in this patch set. > > We've seen quite

Re: [libvirt] [PATCH 0/7] Address some Coverity found issues

2015-07-02 Thread Michal Privoznik
On 01.07.2015 16:03, John Ferlan wrote: > I'm picking a random Coverity thread to express my latest thoughts on this. I'm not trying to say the problems I'm raising are necessarily introduced here in this patch set. We've seen quite a lot of false positives lately. I'm not familiar with coverity,

Re: [libvirt] [PATCH 0/7] Address some Coverity found issues

2015-07-01 Thread John Ferlan
On 07/01/2015 10:03 AM, John Ferlan wrote: ... > > John Ferlan (7): > util: Resolve Coverity FORWARD_NULL > util: Resolve Coverity FORWARD_NULL > util: Resolve Coverity FORWARD_NULL > Avoid Coverity FORWARD_NULL prior to strtok_r calls > phyp: Resolve Coverity FORWARD_NULL > util: Re

Re: [libvirt] [PATCH 0/7] Address some Coverity found issues

2015-07-01 Thread John Ferlan
On 07/01/2015 10:20 AM, Peter Krempa wrote: > On Wed, Jul 01, 2015 at 10:03:44 -0400, John Ferlan wrote: >> The following Coverity issues are flagged in Coverity 7.6.1 compared >> to not being seen in 7.5.1 - this series just addresses those issues >> before 7.6.1 is installed in our upstream Jen

Re: [libvirt] [PATCH 0/7] Address some Coverity found issues

2015-07-01 Thread Peter Krempa
On Wed, Jul 01, 2015 at 10:03:44 -0400, John Ferlan wrote: > The following Coverity issues are flagged in Coverity 7.6.1 compared > to not being seen in 7.5.1 - this series just addresses those issues > before 7.6.1 is installed in our upstream Jenkins environment: > > http://jenkins-virt.usersys.

[libvirt] [PATCH 0/7] Address some Coverity found issues

2015-07-01 Thread John Ferlan
The following Coverity issues are flagged in Coverity 7.6.1 compared to not being seen in 7.5.1 - this series just addresses those issues before 7.6.1 is installed in our upstream Jenkins environment: http://jenkins-virt.usersys.redhat.com/job/libvirt-coverity/ It seems the bulk are essentially f