Re: [libvirt] [PATCH 0/7] tests: Always fake root directory

2015-12-13 Thread Andrea Bolognani
On Fri, 2015-12-04 at 17:07 +0100, Andrea Bolognani wrote: > On Fri, 2015-12-04 at 16:31 +0100, Michal Privoznik wrote: > > ACK, although I'd rather wait until after release. If you (or somebody > > else) feels otherwise, do push it any time you want. > > No need to rush, I'll push after release.

Re: [libvirt] [PATCH 0/7] tests: Always fake root directory

2015-12-04 Thread Andrea Bolognani
On Fri, 2015-12-04 at 16:31 +0100, Michal Privoznik wrote: > ACK, although I'd rather wait until after release. If you (or somebody > else) feels otherwise, do push it any time you want. No need to rush, I'll push after release. Thanks for the review! -- Andrea Bolognani Software Engineer -

Re: [libvirt] [PATCH 0/7] tests: Always fake root directory

2015-12-04 Thread Michal Privoznik
On 04.12.2015 15:34, Andrea Bolognani wrote: > When mocking filesystem access in the test suite, we have always > assumed it to be some subdirectory of /sys depending on the needs > of the specific test case. > > This limits our flexibility, and will be a problem once we need > to start mocking

[libvirt] [PATCH 0/7] tests: Always fake root directory

2015-12-04 Thread Andrea Bolognani
When mocking filesystem access in the test suite, we have always assumed it to be some subdirectory of /sys depending on the needs of the specific test case. This limits our flexibility, and will be a problem once we need to start mocking eg. /dev as well, or simply two different parts of the