Re: [libvirt] [PATCH 00/11] Revisit xen driver Coverity cleanup changes

2013-02-11 Thread John Ferlan
Thanks for the reviews - this is now pushed John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 00/11] Revisit xen driver Coverity cleanup changes

2013-02-08 Thread Eric Blake
On 02/08/2013 04:15 PM, Jim Fehlig wrote: >> I was trying to go with the 80 column rule. For 99% they could fit on >> one line if I removed one extra space. For a couple, spanning 2 lines >> kept the 80 columns in effect. In looking at other drivers - I don't >> think any of them typecast the *Pri

Re: [libvirt] [PATCH 00/11] Revisit xen driver Coverity cleanup changes

2013-02-08 Thread Jim Fehlig
John Ferlan wrote: > On 01/30/2013 01:51 PM, John Ferlan wrote: > >> src/xen/xen_hypervisor.c | 220 -- >> src/xen/xen_inotify.c| 48 >> src/xen/xend_internal.c | 303 >> ++- >> src/xen/xm_internal.c

Re: [libvirt] [PATCH 00/11] Revisit xen driver Coverity cleanup changes

2013-02-08 Thread John Ferlan
On 01/30/2013 01:51 PM, John Ferlan wrote: > src/xen/xen_hypervisor.c | 220 -- > src/xen/xen_inotify.c| 48 > src/xen/xend_internal.c | 303 > ++- > src/xen/xm_internal.c| 195 ++---

[libvirt] [PATCH 00/11] Revisit xen driver Coverity cleanup changes

2013-01-30 Thread John Ferlan
This is a rework of a couple of patches. Initially the changes were to just remove some Coverity warnings; however, it was pointed out that each of the xen drivers could use some cleanup since they were duplicating checks in libvirt.c, see: https://www.redhat.com/archives/libvir-list/2013-January