[getting back to this after *loong* time, sorry]
On Fri, Jul 17, 2015 at 02:30:20PM +0200, Erik Skultety wrote:
Actually, I found out this is easier to review as a one patch with
various diff options used for various parts of the patch. Some
questions and suggestions below.
Why vshClientHooks
> Actually, I found out this is easier to review as a one patch with
> various diff options used for various parts of the patch. Some
> questions and suggestions below.
>
> Why vshClientHooks and vshCmdGrp aren't in the vshControl struct? If
> we move the client helpers into a library (I think t
On Mon, Jun 29, 2015 at 05:37:34PM +0200, Erik Skultety wrote:
The idea behind this is that in order to introduce virt-admin client (and later
some commands/APIs), there are lots of methods in virsh that can be easily
reused by other potential clients like command and command argument passing or
>>>
>>
>> This is rather big change. Do you perhaps have a public repo with all
>> the patches applied?
>>
>
> I've also noticed 03/13 is missing.
>
> Michal
>
I do have it in my inbox (I always CC myself when sending patches), I've
also sent another copy earlier today... still nothing. I have
>
> This is rather big change. Do you perhaps have a public repo with all
> the patches applied?
>
> Michal
I forked libvirt mirror repo on github and pushed as my local branch
virt-shell https://github.com/eskultety/libvirt/tree/virt-shell.
Erik
--
libvir-list mailing list
libvir-list@redhat.
On 30.06.2015 16:12, Michal Privoznik wrote:
> On 29.06.2015 17:37, Erik Skultety wrote:
>> The idea behind this is that in order to introduce virt-admin client (and
>> later
>> some commands/APIs), there are lots of methods in virsh that can be easily
>> reused by other potential clients like com
On 29.06.2015 17:37, Erik Skultety wrote:
> The idea behind this is that in order to introduce virt-admin client (and
> later
> some commands/APIs), there are lots of methods in virsh that can be easily
> reused by other potential clients like command and command argument passing or
> error report
The idea behind this is that in order to introduce virt-admin client (and later
some commands/APIs), there are lots of methods in virsh that can be easily
reused by other potential clients like command and command argument passing or
error reporting.
!!! IMPORTANT !!!
These patches cannot be compi
