Re: [libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)

2019-03-22 Thread Daniel P . Berrangé
On Fri, Mar 22, 2019 at 12:33:25PM +0100, Andrea Bolognani wrote: > On Fri, 2019-03-22 at 11:26 +, Daniel P. Berrangé wrote: > > On Fri, Mar 22, 2019 at 07:10:05AM -0400, John Ferlan wrote: > > > On 3/22/19 7:04 AM, Andrea Bolognani wrote: > > > > Michal's patch seems to do the trick: I built f

Re: [libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)

2019-03-22 Thread Andrea Bolognani
On Fri, 2019-03-22 at 11:26 +, Daniel P. Berrangé wrote: > On Fri, Mar 22, 2019 at 07:10:05AM -0400, John Ferlan wrote: > > On 3/22/19 7:04 AM, Andrea Bolognani wrote: > > > Michal's patch seems to do the trick: I built from 5e752513d802 > > > and the daemon starts fine even when I have guests

Re: [libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)

2019-03-22 Thread Daniel P . Berrangé
On Fri, Mar 22, 2019 at 07:10:05AM -0400, John Ferlan wrote: > > > On 3/22/19 7:04 AM, Andrea Bolognani wrote: > > On Fri, 2019-03-22 at 06:50 -0400, John Ferlan wrote: > >> On 3/22/19 4:46 AM, Andrea Bolognani wrote: > >>> This causes libvirtd to crash at startup on my machine. > >>> > >>> Have

Re: [libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)

2019-03-22 Thread John Ferlan
On 3/22/19 7:04 AM, Andrea Bolognani wrote: > On Fri, 2019-03-22 at 06:50 -0400, John Ferlan wrote: >> On 3/22/19 4:46 AM, Andrea Bolognani wrote: >>> This causes libvirtd to crash at startup on my machine. >>> >>> Have a backtrace: >>> >>> Thread 19 (Thread 0x7fffaa4e0700 (LWP 31651)): >>>

Re: [libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)

2019-03-22 Thread Andrea Bolognani
On Fri, 2019-03-22 at 06:50 -0400, John Ferlan wrote: > On 3/22/19 4:46 AM, Andrea Bolognani wrote: > > This causes libvirtd to crash at startup on my machine. > > > > Have a backtrace: > > > > Thread 19 (Thread 0x7fffaa4e0700 (LWP 31651)): > > #0 0x772ecd31 in open64 () from /lib64/

Re: [libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)

2019-03-22 Thread John Ferlan
On 3/22/19 4:46 AM, Andrea Bolognani wrote: > On Wed, 2019-03-20 at 00:40 -0500, Eric Blake wrote: >> A couple of these have seen the list before, but most of them are >> new. The bulk of this series is about refactoring snapshot_conf.c into >> smaller pieces that I can then reuse for implementi

Re: [libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)

2019-03-22 Thread Erik Skultety
On Fri, Mar 22, 2019 at 09:46:51AM +0100, Andrea Bolognani wrote: > On Wed, 2019-03-20 at 00:40 -0500, Eric Blake wrote: > > A couple of these have seen the list before, but most of them are > > new. The bulk of this series is about refactoring snapshot_conf.c into > > smaller pieces that I can the

Re: [libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)

2019-03-22 Thread Andrea Bolognani
On Wed, 2019-03-20 at 00:40 -0500, Eric Blake wrote: > A couple of these have seen the list before, but most of them are > new. The bulk of this series is about refactoring snapshot_conf.c into > smaller pieces that I can then reuse for implementing checkpoints, > without having to open-code the hi

Re: [libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)

2019-03-21 Thread Eric Blake
On 3/20/19 12:40 AM, Eric Blake wrote: > A couple of these have seen the list before, but most of them are > new. The bulk of this series is about refactoring snapshot_conf.c into > smaller pieces that I can then reuse for implementing checkpoints, > without having to open-code the hierarchy algori

[libvirt] [PATCH 00/16] snapshot refactoring (incremental backup saga)

2019-03-19 Thread Eric Blake
A couple of these have seen the list before, but most of them are new. The bulk of this series is about refactoring snapshot_conf.c into smaller pieces that I can then reuse for implementing checkpoints, without having to open-code the hierarchy algorithms a second time (one of John's complaints ag