Re: [libvirt] [PATCH 00/21] Make migration APIs more extensible

2013-06-24 Thread Jiri Denemark
On Thu, Jun 20, 2013 at 11:59:09 +0200, Jiri Denemark wrote: > On Thu, Jun 20, 2013 at 10:42:11 +0200, Michal Privoznik wrote: > > I've not spotted anything obviously wrong in the patch set. But see my > > inline comments to patches. Esp. in 05/21 please do report OOM error for > > virAsprintf (I k

Re: [libvirt] [PATCH 00/21] Make migration APIs more extensible

2013-06-20 Thread Jiri Denemark
On Thu, Jun 20, 2013 at 10:42:11 +0200, Michal Privoznik wrote: > I've not spotted anything obviously wrong in the patch set. But see my > inline comments to patches. Esp. in 05/21 please do report OOM error for > virAsprintf (I know I promised virAsprintf to report OOM error and I got > patches re

Re: [libvirt] [PATCH 00/21] Make migration APIs more extensible

2013-06-20 Thread Michal Privoznik
On 18.06.2013 16:05, Jiri Denemark wrote: > Current migration APIs support a fixed set of optional parameters and > whenever there is a need for a new parameter, a whole bunch of new > internal and external APIs have to be introduced. This patch set > introduces new extensible APIs that use virType

[libvirt] [PATCH 00/21] Make migration APIs more extensible

2013-06-18 Thread Jiri Denemark
Current migration APIs support a fixed set of optional parameters and whenever there is a need for a new parameter, a whole bunch of new internal and external APIs have to be introduced. This patch set introduces new extensible APIs that use virTypedParameters for passing optional parameters to a m