Re: [libvirt] [PATCH 01/13] Introduce a new public API for domain events

2010-03-22 Thread Daniel Veillard
On Fri, Mar 19, 2010 at 03:38:49PM +, Daniel P. Berrange wrote: The current API for domain events has a number of problems - Only allows for domain lifecycle change events - Does not allow the same callback to be registered multiple times - Does not allow filtering of events to a

[libvirt] [PATCH 01/13] Introduce a new public API for domain events

2010-03-19 Thread Daniel P. Berrange
The current API for domain events has a number of problems - Only allows for domain lifecycle change events - Does not allow the same callback to be registered multiple times - Does not allow filtering of events to a specific domain This introduces a new more general purpose domain events API

Re: [libvirt] [PATCH 01/13] Introduce a new public API for domain events

2010-03-19 Thread Eric Blake
On 03/19/2010 09:38 AM, Daniel P. Berrange wrote: Since different event types can received different data in the callback, the API is defined with a generic callback. Specific events will each have a custom signature for their callback. Thus when registering an event it is neccessary to cast

Re: [libvirt] [PATCH 01/13] Introduce a new public API for domain events

2010-03-19 Thread Daniel P. Berrange
On Fri, Mar 19, 2010 at 11:06:40AM -0600, Eric Blake wrote: On 03/19/2010 09:38 AM, Daniel P. Berrange wrote: Since different event types can received different data in the callback, the API is defined with a generic callback. Specific events will each have a custom signature for their