Re: [libvirt] [PATCH 01/14] Avoid polluting logs when querying LVM/SCSI ID

2012-12-12 Thread Michal Privoznik
On 11.12.2012 21:41, Daniel P. Berrange wrote: > From: "Daniel P. Berrange" > > When we invoke lvs or scsi_id to extract ID for block devices, we > don't want virCommandWait logging errors messages. Thus we must > explicitly check 'status != 0', rather than letting virCommandWait do > it. Also mo

Re: [libvirt] [PATCH 01/14] Avoid polluting logs when querying LVM/SCSI ID

2012-12-11 Thread Peter Krempa
On 12/11/12 21:41, Daniel P. Berrange wrote: From: "Daniel P. Berrange" When we invoke lvs or scsi_id to extract ID for block devices, we don't want virCommandWait logging errors messages. Thus we must explicitly check 'status != 0', rather than letting virCommandWait do it. Also move the check

[libvirt] [PATCH 01/14] Avoid polluting logs when querying LVM/SCSI ID

2012-12-11 Thread Daniel P. Berrange
From: "Daniel P. Berrange" When we invoke lvs or scsi_id to extract ID for block devices, we don't want virCommandWait logging errors messages. Thus we must explicitly check 'status != 0', rather than letting virCommandWait do it. Also move the check for converting from "" to NULL, after the clea