Re: [libvirt] [PATCH 01/23] qemu: driver: Don't call qemuDomainDetermineDiskChain on block jobs

2017-03-23 Thread Peter Krempa
On Thu, Mar 23, 2017 at 10:31:06 -0500, Eric Blake wrote: > On 03/23/2017 02:13 AM, Peter Krempa wrote: > > On Wed, Mar 22, 2017 at 14:21:29 -0500, Eric Blake wrote: > >> On 03/15/2017 11:37 AM, Peter Krempa wrote: > >>> Our code calls it when starting or re-starting the domain or when > >>> hotplu

Re: [libvirt] [PATCH 01/23] qemu: driver: Don't call qemuDomainDetermineDiskChain on block jobs

2017-03-23 Thread Eric Blake
On 03/23/2017 02:13 AM, Peter Krempa wrote: > On Wed, Mar 22, 2017 at 14:21:29 -0500, Eric Blake wrote: >> On 03/15/2017 11:37 AM, Peter Krempa wrote: >>> Our code calls it when starting or re-starting the domain or when >>> hotplugging the disk so there's nothing to be detected. >>> --- >>> src/q

Re: [libvirt] [PATCH 01/23] qemu: driver: Don't call qemuDomainDetermineDiskChain on block jobs

2017-03-23 Thread Peter Krempa
On Wed, Mar 22, 2017 at 14:21:29 -0500, Eric Blake wrote: > On 03/15/2017 11:37 AM, Peter Krempa wrote: > > Our code calls it when starting or re-starting the domain or when > > hotplugging the disk so there's nothing to be detected. > > --- > > src/qemu/qemu_driver.c | 5 - > > 1 file changed

Re: [libvirt] [PATCH 01/23] qemu: driver: Don't call qemuDomainDetermineDiskChain on block jobs

2017-03-22 Thread Eric Blake
On 03/15/2017 11:37 AM, Peter Krempa wrote: > Our code calls it when starting or re-starting the domain or when > hotplugging the disk so there's nothing to be detected. > --- > src/qemu/qemu_driver.c | 5 - > 1 file changed, 5 deletions(-) > I think I added it here because block jobs have t

[libvirt] [PATCH 01/23] qemu: driver: Don't call qemuDomainDetermineDiskChain on block jobs

2017-03-15 Thread Peter Krempa
Our code calls it when starting or re-starting the domain or when hotplugging the disk so there's nothing to be detected. --- src/qemu/qemu_driver.c | 5 - 1 file changed, 5 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2032fac71..06bd442ee 100644 --- a/src/q