Re: [libvirt] [PATCH 02/10] rbd: drop support for ceph 0.94

2019-04-03 Thread Daniel P . Berrangé
On Wed, Apr 03, 2019 at 07:40:17AM +0200, Ján Tomko wrote: > Commit 21deeaf02fdf216b08210fc899579736973ca81d added a stub > for volStorageBackendRBDGetFlags without marking the arguments > as unused, thus breaking the build. IMHO we should just add the attribute annotation for fix the warning

[libvirt] [PATCH 02/10] rbd: drop support for ceph 0.94

2019-04-02 Thread Ján Tomko
Commit 21deeaf02fdf216b08210fc899579736973ca81d added a stub for volStorageBackendRBDGetFlags without marking the arguments as unused, thus breaking the build. Now that we require diff_iterate2 to be present, remove all the conditionally compiled code, including the stub function. Signed-off-by: