Re: [libvirt] [PATCH 02/15] conf: nodedev: Rename virNodeDeviceCapMatch to virNodeDevObjHasCap

2018-01-29 Thread Michal Privoznik
On 01/29/2018 09:47 AM, Erik Skultety wrote: > On Fri, Jan 26, 2018 at 12:40:46PM +0100, Michal Privoznik wrote: >> On 01/25/2018 10:23 AM, Erik Skultety wrote: >>> We currently have 2 methods that do the capability matching. This should >>> be condensed to a single function and all the derivates s

Re: [libvirt] [PATCH 02/15] conf: nodedev: Rename virNodeDeviceCapMatch to virNodeDevObjHasCap

2018-01-29 Thread Erik Skultety
On Fri, Jan 26, 2018 at 12:40:46PM +0100, Michal Privoznik wrote: > On 01/25/2018 10:23 AM, Erik Skultety wrote: > > We currently have 2 methods that do the capability matching. This should > > be condensed to a single function and all the derivates should just call > > into that using a proper typ

Re: [libvirt] [PATCH 02/15] conf: nodedev: Rename virNodeDeviceCapMatch to virNodeDevObjHasCap

2018-01-26 Thread Michal Privoznik
On 01/25/2018 10:23 AM, Erik Skultety wrote: > We currently have 2 methods that do the capability matching. This should > be condensed to a single function and all the derivates should just call > into that using a proper type conversion. > > Signed-off-by: Erik Skultety > --- > src/conf/virnode

[libvirt] [PATCH 02/15] conf: nodedev: Rename virNodeDeviceCapMatch to virNodeDevObjHasCap

2018-01-25 Thread Erik Skultety
We currently have 2 methods that do the capability matching. This should be condensed to a single function and all the derivates should just call into that using a proper type conversion. Signed-off-by: Erik Skultety --- src/conf/virnodedeviceobj.c | 8 +--- 1 file changed, 5 insertions(+),