Re: [libvirt] [PATCH 02/16] util: Combine __virExec and virExecWithHook

2011-05-13 Thread Cole Robinson
On 05/10/2011 07:07 PM, Eric Blake wrote: > On 05/10/2011 02:07 PM, Cole Robinson wrote: >> All callers were expecting argv logging, so the split is unneeded. > > Not quite true - virCommandRunAsync already does an independent > VIR_DEBUG of argv/envp prior to calling virExecWithHook, so we are >

Re: [libvirt] [PATCH 02/16] util: Combine __virExec and virExecWithHook

2011-05-10 Thread Eric Blake
On 05/10/2011 02:07 PM, Cole Robinson wrote: > All callers were expecting argv logging, so the split is unneeded. Not quite true - virCommandRunAsync already does an independent VIR_DEBUG of argv/envp prior to calling virExecWithHook, so we are actually doing double-duty at the moment. But that c

[libvirt] [PATCH 02/16] util: Combine __virExec and virExecWithHook

2011-05-10 Thread Cole Robinson
All callers were expecting argv logging, so the split is unneeded. Signed-off-by: Cole Robinson --- src/util/util.c | 86 ++ 1 files changed, 35 insertions(+), 51 deletions(-) diff --git a/src/util/util.c b/src/util/util.c index 1d0c2cc..f86