Re: [libvirt] [PATCH 02/17] nwfilter: Fix possible corruption on failure path during LoadConfig

2017-07-15 Thread John Ferlan
On 07/14/2017 08:09 AM, Michal Privoznik wrote: > On 07/14/2017 01:50 AM, John Ferlan wrote: >> >> >> On 07/13/2017 10:41 AM, Michal Privoznik wrote: >>> On 06/02/2017 12:25 PM, John Ferlan wrote: If the virNWFilterSaveConfig in virNWFilterObjListLoadConfig, then jumping >>> >>> s/,/

Re: [libvirt] [PATCH 02/17] nwfilter: Fix possible corruption on failure path during LoadConfig

2017-07-14 Thread Michal Privoznik
On 07/14/2017 01:50 AM, John Ferlan wrote: > > > On 07/13/2017 10:41 AM, Michal Privoznik wrote: >> On 06/02/2017 12:25 PM, John Ferlan wrote: >>> If the virNWFilterSaveConfig in virNWFilterObjListLoadConfig, then jumping >> >> s/,/ fails,/ >> >>> to the error label would free the @def owned by

Re: [libvirt] [PATCH 02/17] nwfilter: Fix possible corruption on failure path during LoadConfig

2017-07-13 Thread John Ferlan
On 07/13/2017 10:41 AM, Michal Privoznik wrote: > On 06/02/2017 12:25 PM, John Ferlan wrote: >> If the virNWFilterSaveConfig in virNWFilterObjListLoadConfig, then jumping > > s/,/ fails,/ > >> to the error label would free the @def owned by the object, but the object >> is still on the list.

[libvirt] [PATCH 02/17] nwfilter: Fix possible corruption on failure path during LoadConfig

2017-06-02 Thread John Ferlan
If the virNWFilterSaveConfig in virNWFilterObjListLoadConfig, then jumping to the error label would free the @def owned by the object, but the object is still on the list. Fix this by following proper procedure to clear @def and create a new variable @objdef to handle the object's def after