Re: [libvirt] [PATCH 02/17] qemu: Introduce qemuDomainDeviceDefSkipController

2017-12-06 Thread Ján Tomko
On Wed, Dec 06, 2017 at 10:18:53AM -0500, John Ferlan wrote: On 12/05/2017 09:18 AM, Ján Tomko wrote: [...] We should not skip validation for implicit devices. Some of the checks added later are for implicit devices (PCI root, SATA controller). It would be enough to split out the logic of

Re: [libvirt] [PATCH 02/17] qemu: Introduce qemuDomainDeviceDefSkipController

2017-12-06 Thread John Ferlan
On 12/05/2017 09:18 AM, Ján Tomko wrote: > On Mon, Dec 04, 2017 at 08:38:52PM -0500, John Ferlan wrote: >> In order to be able to reuse some code for both controller def >> validation and command line building, create a convenience helper >> that will perform the "skip" avoidance checks. It will

Re: [libvirt] [PATCH 02/17] qemu: Introduce qemuDomainDeviceDefSkipController

2017-12-05 Thread John Ferlan
On 12/05/2017 09:18 AM, Ján Tomko wrote: > On Mon, Dec 04, 2017 at 08:38:52PM -0500, John Ferlan wrote: >> In order to be able to reuse some code for both controller def >> validation and command line building, create a convenience helper >> that will perform the "skip" avoidance checks. It will

Re: [libvirt] [PATCH 02/17] qemu: Introduce qemuDomainDeviceDefSkipController

2017-12-05 Thread Ján Tomko
On Mon, Dec 04, 2017 at 08:38:52PM -0500, John Ferlan wrote: In order to be able to reuse some code for both controller def validation and command line building, create a convenience helper that will perform the "skip" avoidance checks. It will also set some flags to allow the caller to

[libvirt] [PATCH 02/17] qemu: Introduce qemuDomainDeviceDefSkipController

2017-12-04 Thread John Ferlan
In order to be able to reuse some code for both controller def validation and command line building, create a convenience helper that will perform the "skip" avoidance checks. It will also set some flags to allow the caller to specifically skip (or fail) depending on the result of the flag (as