Re: [libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

2018-04-03 Thread Marc Hartmayer
On Tue, Apr 03, 2018 at 02:05 PM +0200, "Daniel P. Berrangé" wrote: > On Tue, Apr 03, 2018 at 01:46:13PM +0200, Marc Hartmayer wrote: >> On Wed, Mar 21, 2018 at 07:57 AM +0100, Marc Hartmayer >> wrote: >> > On Mon, Mar 19, 2018 at 04:06 PM

Re: [libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

2018-04-03 Thread Daniel P . Berrangé
On Tue, Apr 03, 2018 at 01:46:13PM +0200, Marc Hartmayer wrote: > On Wed, Mar 21, 2018 at 07:57 AM +0100, Marc Hartmayer > wrote: > > On Mon, Mar 19, 2018 at 04:06 PM +0100, "Daniel P. Berrangé" > > wrote: > >> On Thu, Mar 08, 2018 at

Re: [libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

2018-04-03 Thread Marc Hartmayer
On Wed, Mar 21, 2018 at 07:57 AM +0100, Marc Hartmayer wrote: > On Mon, Mar 19, 2018 at 04:06 PM +0100, "Daniel P. Berrangé" > wrote: >> On Thu, Mar 08, 2018 at 01:20:25PM +0100, Marc Hartmayer wrote: >>> Don't assume that the feature

Re: [libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

2018-03-21 Thread Marc Hartmayer
On Mon, Mar 19, 2018 at 04:06 PM +0100, "Daniel P. Berrangé" wrote: > On Thu, Mar 08, 2018 at 01:20:25PM +0100, Marc Hartmayer wrote: >> Don't assume that the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK is >> available for every driver used for the connection. > > The very

Re: [libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

2018-03-19 Thread Daniel P . Berrangé
On Thu, Mar 08, 2018 at 01:20:25PM +0100, Marc Hartmayer wrote: > Don't assume that the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK is > available for every driver used for the connection. The very definition of the virConnectRegisterCloseCallback() API is that it will always succeed. What

Re: [libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

2018-03-16 Thread Nikolay Shirokovskiy
On 15.03.2018 21:52, Marc Hartmayer wrote: > On Thu, Mar 15, 2018 at 12:02 AM +0100, John Ferlan > wrote: >> On 03/14/2018 05:30 PM, John Ferlan wrote: >>> >>> >>> On 03/08/2018 07:20 AM, Marc Hartmayer wrote: Don't assume that the feature

Re: [libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

2018-03-15 Thread Marc Hartmayer
On Thu, Mar 15, 2018 at 12:02 AM +0100, John Ferlan wrote: > On 03/14/2018 05:30 PM, John Ferlan wrote: >> >> >> On 03/08/2018 07:20 AM, Marc Hartmayer wrote: >>> Don't assume that the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK is >>> available for every driver used for the

Re: [libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

2018-03-15 Thread John Ferlan
On 03/14/2018 05:30 PM, John Ferlan wrote: > > > On 03/08/2018 07:20 AM, Marc Hartmayer wrote: >> Don't assume that the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK is >> available for every driver used for the connection. >> >> Signed-off-by: Marc Hartmayer >>

Re: [libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

2018-03-15 Thread John Ferlan
On 03/08/2018 07:20 AM, Marc Hartmayer wrote: > Don't assume that the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK is > available for every driver used for the connection. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Bjoern Walk >

[libvirt] [PATCH 02/20] remote: Don't hard code the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK as available

2018-03-08 Thread Marc Hartmayer
Don't assume that the feature VIR_DRV_FEATURE_REMOTE_CLOSE_CALLBACK is available for every driver used for the connection. Signed-off-by: Marc Hartmayer Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski ---