Re: [libvirt] [PATCH 02/23] util: buffer: Add API to set indentation level to a given value

2017-03-23 Thread Eric Blake
On 03/23/2017 02:14 AM, Peter Krempa wrote: >> >> No testsuite addition? > > For such trivial operation? I think we have pretty strong coverage of > the indentation code. This simple setter isn't worth it IMO. I don't see how adding one or two lines to the testsuite, to ensure we don't break thi

Re: [libvirt] [PATCH 02/23] util: buffer: Add API to set indentation level to a given value

2017-03-23 Thread Peter Krempa
On Wed, Mar 22, 2017 at 14:27:18 -0500, Eric Blake wrote: > On 03/15/2017 11:37 AM, Peter Krempa wrote: > > It will be useful to set indentation level to 0 after formatting a > > nested structure rather than having to track the depth. > > --- > > src/libvirt_private.syms | 1 + > > src/util/virbu

Re: [libvirt] [PATCH 02/23] util: buffer: Add API to set indentation level to a given value

2017-03-22 Thread Eric Blake
On 03/15/2017 11:37 AM, Peter Krempa wrote: > It will be useful to set indentation level to 0 after formatting a > nested structure rather than having to track the depth. > --- > src/libvirt_private.syms | 1 + > src/util/virbuffer.c | 19 +++ > src/util/virbuffer.h | 2 +

[libvirt] [PATCH 02/23] util: buffer: Add API to set indentation level to a given value

2017-03-15 Thread Peter Krempa
It will be useful to set indentation level to 0 after formatting a nested structure rather than having to track the depth. --- src/libvirt_private.syms | 1 + src/util/virbuffer.c | 19 +++ src/util/virbuffer.h | 2 ++ 3 files changed, 22 insertions(+) diff --git a/src/l