Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private

2017-06-12 Thread Laine Stump
On 06/12/2017 05:20 AM, Andrea Bolognani wrote: > On Mon, 2017-06-12 at 08:35 +0200, Ján Tomko wrote: >>> Reviewed-by: Laine Stump >>> >>> (This *is* the new hot way to say ACK, right?) >> >> It is not a replacement (AFAIK only rebels like John and Pavel use it) >> and it is

Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private

2017-06-12 Thread Andrea Bolognani
On Mon, 2017-06-12 at 08:35 +0200, Ján Tomko wrote: > > Reviewed-by: Laine Stump > >  > > (This *is* the new hot way to say ACK, right?) >  > It is not a replacement (AFAIK only rebels like John and Pavel use it) > and it is not an equivalent (with Reviewed-by, I assume the

Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private

2017-06-12 Thread Ján Tomko
On Sun, Jun 11, 2017 at 10:10:39PM -0400, Laine Stump wrote: Reviewed-by: Laine Stump (This *is* the new hot way to say ACK, right?) It is not a replacement (AFAIK only rebels like John and Pavel use it) and it is not an equivalent (with Reviewed-by, I assume the reviewer

Re: [libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private

2017-06-11 Thread Laine Stump
On 06/02/2017 12:07 PM, Andrea Bolognani wrote: > There are no external users. > --- > src/conf/domain_addr.c | 2 +- > src/conf/domain_addr.h | 5 - > src/libvirt_private.syms | 1 - > 3 files changed, 1 insertion(+), 7 deletions(-) > > diff --git a/src/conf/domain_addr.c

[libvirt] [PATCH 02/26] conf: Make virDomainPCIAddressSetGrow() private

2017-06-02 Thread Andrea Bolognani
There are no external users. --- src/conf/domain_addr.c | 2 +- src/conf/domain_addr.h | 5 - src/libvirt_private.syms | 1 - 3 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 639168e..9c809e8 100644 ---