Re: [libvirt] [PATCH 02/48] Destroy virdomainlist.[ch]

2012-08-14 Thread Eric Blake
On 08/14/2012 03:28 AM, Osier Yang wrote: >> for (i = 0; i< count; i++) { >> if (data.domains[i]) >> -virUnrefDomain(data.domains[i]); > > Not sure if it will cause conflicts to you, but the "if" is removed > for "avoid_if_before_free". Nah, 'make syntax-

Re: [libvirt] [PATCH 02/48] Destroy virdomainlist.[ch]

2012-08-14 Thread Osier Yang
On 2012年08月14日 07:53, Eric Blake wrote: On 08/03/2012 09:48 AM, Osier Yang wrote: As the consensus in: https://www.redhat.com/archives/libvir-list/2012-July/msg01692.html, this patch is to destroy conf/virdomainlist.[ch], foldering the s/foldering/folding/ helpers into conf/domain_conf.[ch].

Re: [libvirt] [PATCH 02/48] Destroy virdomainlist.[ch]

2012-08-13 Thread Eric Blake
On 08/03/2012 09:48 AM, Osier Yang wrote: > As the consensus in: > https://www.redhat.com/archives/libvir-list/2012-July/msg01692.html, > this patch is to destroy conf/virdomainlist.[ch], foldering the s/foldering/folding/ > helpers into conf/domain_conf.[ch]. > * src/Makefile.am: > - Various

[libvirt] [PATCH 02/48] Destroy virdomainlist.[ch]

2012-08-03 Thread Osier Yang
As the consensus in: https://www.redhat.com/archives/libvir-list/2012-July/msg01692.html, this patch is to destroy conf/virdomainlist.[ch], foldering the helpers into conf/domain_conf.[ch]. * src/Makefile.am: - Various indentions fixes incidentally - Add macro DATATYPES_SOURCES (datatypes.[ch]