Re: [libvirt] [PATCH 03/10] Add an internal secret XML handling API

2009-09-08 Thread Daniel Veillard
On Mon, Sep 07, 2009 at 04:12:38PM +0200, Miloslav Trmač wrote: Add a secret XML handling API, separate from the local driver, to avoid manually generating XML in other parts of libvirt. * src/secret_conf.c, src/secret_conf.h: New files. * po/POTFILES.in, src/Makefile.am: Add secret_conf.

Re: [libvirt] [PATCH 03/10] Add an internal secret XML handling API

2009-09-08 Thread Miloslav Trmac
- Daniel Veillard veill...@redhat.com wrote: +default: +VIR_ERROR(_(unexpected secret usage type %d), def-usage_type); +break; Hum, since the virSecretDefPtr is allocated by our own code, it's probably better to remove the default so that the compiler can

[libvirt] [PATCH 03/10] Add an internal secret XML handling API

2009-09-07 Thread Miloslav Trmač
Add a secret XML handling API, separate from the local driver, to avoid manually generating XML in other parts of libvirt. * src/secret_conf.c, src/secret_conf.h: New files. * po/POTFILES.in, src/Makefile.am: Add secret_conf. --- po/POTFILES.in |1 + src/Makefile.am |7