Re: [libvirt] [PATCH 03/10] util: Introduce virFileFlock

2018-06-07 Thread Ján Tomko
On Thu, Jun 07, 2018 at 03:54:24PM +0200, Martin Kletzander wrote: We already have virFileLock(), but we are now using flock() in the code as well (due to requirements for mutual exclusion between libvirt and other programs using flock() as well), so let's have a function for that as well so we

Re: [libvirt] [PATCH 03/10] util: Introduce virFileFlock

2018-06-07 Thread Martin Kletzander
On Thu, Jun 07, 2018 at 02:58:12PM +0100, Daniel P. Berrangé wrote: On Thu, Jun 07, 2018 at 03:54:24PM +0200, Martin Kletzander wrote: We already have virFileLock(), but we are now using flock() in the code as well (due to requirements for mutual exclusion between libvirt and other programs

Re: [libvirt] [PATCH 03/10] util: Introduce virFileFlock

2018-06-07 Thread Daniel P . Berrangé
On Thu, Jun 07, 2018 at 03:54:24PM +0200, Martin Kletzander wrote: > We already have virFileLock(), but we are now using flock() in the code as > well (due to requirements for mutual exclusion between libvirt and other > programs using flock() as well), so let's have a function for that as well so

[libvirt] [PATCH 03/10] util: Introduce virFileFlock

2018-06-07 Thread Martin Kletzander
We already have virFileLock(), but we are now using flock() in the code as well (due to requirements for mutual exclusion between libvirt and other programs using flock() as well), so let's have a function for that as well so we don't need to have stubs for unsupported platforms in other files.