Re: [libvirt] [PATCH 03/11] caps: Use an enum internally for ostype value

2015-04-21 Thread Cole Robinson
On 04/21/2015 05:22 AM, Christophe Fergeau wrote: > Hey, > > On Fri, Apr 17, 2015 at 09:45:13PM -0400, Cole Robinson wrote: >> +VIR_ENUM_IMPL(virDomainOS, VIR_DOMAIN_OSTYPE_LAST, >> + "hvm", >> + "xen", >> + "linux", >> + "exe", >> +

Re: [libvirt] [PATCH 03/11] caps: Use an enum internally for ostype value

2015-04-21 Thread Christophe Fergeau
Hey, On Fri, Apr 17, 2015 at 09:45:13PM -0400, Cole Robinson wrote: > +VIR_ENUM_IMPL(virDomainOS, VIR_DOMAIN_OSTYPE_LAST, > + "hvm", > + "xen", > + "linux", > + "exe", > + "uml", > + "aix") > + This is preexisting befor

Re: [libvirt] [PATCH 03/11] caps: Use an enum internally for ostype value

2015-04-20 Thread Michal Privoznik
On 18.04.2015 03:45, Cole Robinson wrote: > But the internal API stays the same, and we just convert the value as > needed. Not useful yet, but this is the beginning step of using an enum > for ostype throughout the code. > --- > src/conf/capabilities.c | 74 >

[libvirt] [PATCH 03/11] caps: Use an enum internally for ostype value

2015-04-17 Thread Cole Robinson
But the internal API stays the same, and we just convert the value as needed. Not useful yet, but this is the beginning step of using an enum for ostype throughout the code. --- src/conf/capabilities.c | 74 ++--- src/conf/capabilities.h | 2 +- src/con