Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-10-01 Thread Peter Krempa
On Mon, Oct 01, 2018 at 14:58:11 +0200, Marc Hartmayer wrote: > On Mon, Oct 01, 2018 at 12:36 PM +0200, Peter Krempa > wrote: [...] > >> Yep, that’s why I said in the cover letter “With this patch series the > >> behavior is still not (completely) fixed, but the performance has been > >> signif

Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-10-01 Thread Marc Hartmayer
On Mon, Oct 01, 2018 at 12:36 PM +0200, Peter Krempa wrote: […snip…] >> I would do all the precondition stuff (e.g. the priv->qemuCaps isn’t >> valid anymore) as early as possible in the overall “task/job” process. > > Well, technically priv->qemuCaps is invalid and unneeded when the VM is > not

Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-10-01 Thread Peter Krempa
On Mon, Oct 01, 2018 at 10:31:36 +0200, Marc Hartmayer wrote: > On Mon, Oct 01, 2018 at 09:33 AM +0200, Peter Krempa > wrote: > > On Fri, Sep 28, 2018 at 22:02:59 -0400, John Ferlan wrote: > >> > >> > >> On 9/20/18 1:44 PM, Marc Hartmayer wrote: > >> > ...although priv->qemuCaps will be NULL in a

Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-10-01 Thread Marc Hartmayer
On Mon, Oct 01, 2018 at 09:33 AM +0200, Peter Krempa wrote: > On Fri, Sep 28, 2018 at 22:02:59 -0400, John Ferlan wrote: >> >> >> On 9/20/18 1:44 PM, Marc Hartmayer wrote: >> > ...although priv->qemuCaps will be NULL in almost every case when the >> > post parse callback has failed. That may chang

Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-10-01 Thread Peter Krempa
On Fri, Sep 28, 2018 at 22:02:59 -0400, John Ferlan wrote: > > > On 9/20/18 1:44 PM, Marc Hartmayer wrote: > > ...although priv->qemuCaps will be NULL in almost every case when the > > post parse callback has failed. That may change in the future. > > > > Signed-off-by: Marc Hartmayer > > Revie

Re: [libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-09-28 Thread John Ferlan
On 9/20/18 1:44 PM, Marc Hartmayer wrote: > ...although priv->qemuCaps will be NULL in almost every case when the > post parse callback has failed. That may change in the future. > > Signed-off-by: Marc Hartmayer > Reviewed-by: Boris Fiuczynski > --- > src/qemu/qemu_process.c | 2 +- > 1 fil

[libvirt] [PATCH 03/11] qemu: Pass QEMUCaps to virDomainDefPostParse

2018-09-20 Thread Marc Hartmayer
...although priv->qemuCaps will be NULL in almost every case when the post parse callback has failed. That may change in the future. Signed-off-by: Marc Hartmayer Reviewed-by: Boris Fiuczynski --- src/qemu/qemu_process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qe