Re: [libvirt] [PATCH 03/12] storage: Fix a resource leak in storageVolCreateXML

2015-10-13 Thread Peter Krempa
On Fri, Oct 09, 2015 at 09:34:02 -0400, John Ferlan wrote: > Commit id '1b5685da' refactored the code to move buildvoldef inside > the buildVol conditional; however, the VIR_FREE of the memory was > left only when 'buildret' failed, thus we're leaking memory. > > Signed-off-by: John Ferlan

[libvirt] [PATCH 03/12] storage: Fix a resource leak in storageVolCreateXML

2015-10-09 Thread John Ferlan
Commit id '1b5685da' refactored the code to move buildvoldef inside the buildVol conditional; however, the VIR_FREE of the memory was left only when 'buildret' failed, thus we're leaking memory. Signed-off-by: John Ferlan --- src/storage/storage_driver.c | 3 ++- 1 file