Re: [libvirt] [PATCH 03/12] storage_util: Remove unnecessary check

2018-05-15 Thread Peter Krempa
On Tue, May 08, 2018 at 08:47:56 -0400, John Ferlan wrote: > Commit id 'a48c71411' altered the logic a bit and didn't > remove an unnecessary check as info.encryption is true when > vol->target.encryption != NULL, so if we enter the if segment > with info.format == VIR_STORAGE_FILE_RAW && vol->targ

[libvirt] [PATCH 03/12] storage_util: Remove unnecessary check

2018-05-08 Thread John Ferlan
Commit id 'a48c71411' altered the logic a bit and didn't remove an unnecessary check as info.encryption is true when vol->target.encryption != NULL, so if we enter the if segment with info.format == VIR_STORAGE_FILE_RAW && vol->target.encryption != NULL, then there's no way info.encryption could be