Re: [libvirt] [PATCH 03/17] nwfilter: Fix possible locking problem in LoadConfig error path

2017-07-15 Thread John Ferlan
On 07/14/2017 08:09 AM, Michal Privoznik wrote: > On 07/14/2017 01:52 AM, John Ferlan wrote: >> >> >> On 07/13/2017 10:41 AM, Michal Privoznik wrote: >>> On 06/02/2017 12:25 PM, John Ferlan wrote: After returning from virNWFilterObjListAssignDef the @obj is locked; however, if

Re: [libvirt] [PATCH 03/17] nwfilter: Fix possible locking problem in LoadConfig error path

2017-07-14 Thread Michal Privoznik
On 07/14/2017 01:52 AM, John Ferlan wrote: > > > On 07/13/2017 10:41 AM, Michal Privoznik wrote: >> On 06/02/2017 12:25 PM, John Ferlan wrote: >>> After returning from virNWFilterObjListAssignDef the @obj is locked; >>> however, if virNWFilterSaveConfig fails to save the generated UUID >>> the

Re: [libvirt] [PATCH 03/17] nwfilter: Fix possible locking problem in LoadConfig error path

2017-07-13 Thread John Ferlan
On 07/13/2017 10:41 AM, Michal Privoznik wrote: > On 06/02/2017 12:25 PM, John Ferlan wrote: >> After returning from virNWFilterObjListAssignDef the @obj is locked; >> however, if virNWFilterSaveConfig fails to save the generated UUID >> the code jumped to error and returns NULL meaning the

Re: [libvirt] [PATCH 03/17] nwfilter: Fix possible locking problem in LoadConfig error path

2017-07-13 Thread Michal Privoznik
On 06/02/2017 12:25 PM, John Ferlan wrote: > After returning from virNWFilterObjListAssignDef the @obj is locked; > however, if virNWFilterSaveConfig fails to save the generated UUID > the code jumped to error and returns NULL meaning the caller will > not call virNWFilterObjUnlock on the object

[libvirt] [PATCH 03/17] nwfilter: Fix possible locking problem in LoadConfig error path

2017-06-02 Thread John Ferlan
After returning from virNWFilterObjListAssignDef the @obj is locked; however, if virNWFilterSaveConfig fails to save the generated UUID the code jumped to error and returns NULL meaning the caller will not call virNWFilterObjUnlock on the object leaving the object locked on list and ripe for a