Re: [libvirt] [PATCH 03/26] Remove pointless storage of var names in virNWFilterHashTable

2014-04-14 Thread Stefan Berger
On 04/08/2014 11:37 AM, Daniel P. Berrange wrote: The virNWFilterHashTable struct contains a virHashTable and then a 'char **names' field which keeps a copy of all the hash keys. Presumably this was intended to record the ordering of the hash keys. No code ever uses this and the ordering is

Re: [libvirt] [PATCH 03/26] Remove pointless storage of var names in virNWFilterHashTable

2014-04-14 Thread Eric Blake
On 04/08/2014 09:37 AM, Daniel P. Berrange wrote: The virNWFilterHashTable struct contains a virHashTable and then a 'char **names' field which keeps a copy of all the hash keys. Presumably this was intended to record the ordering of the hash keys. No code ever uses this and the ordering is

[libvirt] [PATCH 03/26] Remove pointless storage of var names in virNWFilterHashTable

2014-04-08 Thread Daniel P. Berrange
The virNWFilterHashTable struct contains a virHashTable and then a 'char **names' field which keeps a copy of all the hash keys. Presumably this was intended to record the ordering of the hash keys. No code ever uses this and the ordering is mangled whenever a variable is removed from the hash,