Re: [libvirt] [PATCH 04/03] qemu: Refactor qemuGetDriveSourceString to take virStorageSourcePtr

2014-04-09 Thread Peter Krempa
On 04/09/14 03:40, Eric Blake wrote: > On 04/08/2014 09:55 AM, Peter Krempa wrote: >> Refactor the function to avoid multiple wrappers splitting identical >> fields from the now common metadata struct. >> >> The refactor is done by folding in the wrapper used for disk sources >> which allows us to

Re: [libvirt] [PATCH 04/03] qemu: Refactor qemuGetDriveSourceString to take virStorageSourcePtr

2014-04-08 Thread Eric Blake
On 04/08/2014 09:55 AM, Peter Krempa wrote: > Refactor the function to avoid multiple wrappers splitting identical > fields from the now common metadata struct. > > The refactor is done by folding in the wrapper used for disk sources > which allows us to lookup secrets via the secret driver. This

[libvirt] [PATCH 04/03] qemu: Refactor qemuGetDriveSourceString to take virStorageSourcePtr

2014-04-08 Thread Peter Krempa
Refactor the function to avoid multiple wrappers splitting identical fields from the now common metadata struct. The refactor is done by folding in the wrapper used for disk sources which allows us to lookup secrets via the secret driver. This may allow using stored secrets for snapshot disk image