Re: [libvirt] [PATCH 04/10] Secret manipulation step 7: Local driver

2009-09-08 Thread Daniel Veillard
On Mon, Sep 07, 2009 at 04:12:39PM +0200, Miloslav Trmač wrote: This implementation stores the secrets in an unencrypted text file, for simplicity in implementation and debugging. (Symmetric encryption, e.g. using gpgme, will not be difficult to add. Because the TLS private key used by

Re: [libvirt] [PATCH 04/10] Secret manipulation step 7: Local driver

2009-09-08 Thread Jim Meyering
Daniel Veillard wrote: On Mon, Sep 07, 2009 at 04:12:39PM +0200, Miloslav Trmač wrote: This implementation stores the secrets in an unencrypted text file, for simplicity in implementation and debugging. (Symmetric encryption, e.g. using gpgme, will not be difficult to add. Because the TLS

Re: [libvirt] [PATCH 04/10] Secret manipulation step 7: Local driver

2009-09-08 Thread Daniel Veillard
On Tue, Sep 08, 2009 at 12:39:44PM +0200, Jim Meyering wrote: Daniel Veillard wrote: On Mon, Sep 07, 2009 at 04:12:39PM +0200, Miloslav Trmač wrote: This implementation stores the secrets in an unencrypted text file, for simplicity in implementation and debugging. (Symmetric encryption,

Re: [libvirt] [PATCH 04/10] Secret manipulation step 7: Local driver

2009-09-08 Thread Miloslav Trmac
- Daniel Veillard veill...@redhat.com wrote: On Mon, Sep 07, 2009 at 04:12:39PM +0200, Miloslav Trmač wrote: +if ((size_t)st.st_size != st.st_size) { shouldn't we chaeck against SECRET_MAX_XML_FILE instead ? No, this code reads the secret value, not the XML, and there's little

[libvirt] [PATCH 04/10] Secret manipulation step 7: Local driver

2009-09-07 Thread Miloslav Trmač
This implementation stores the secrets in an unencrypted text file, for simplicity in implementation and debugging. (Symmetric encryption, e.g. using gpgme, will not be difficult to add. Because the TLS private key used by libvirtd is stored unencrypted, encrypting the secrets file does not