Re: [libvirt] [PATCH 04/10] cgroup: Replace sscanf with virStrToLong_ll

2010-03-31 Thread Matthias Bolte
2010/3/31 Eric Blake ebl...@redhat.com: On 03/30/2010 10:20 AM, Matthias Bolte wrote: -    if (sscanf(strval, % SCNi64, value) != 1) +    if (virStrToLong_ll(strval, NULL, 10, value) 0) Oops.  You effectively changed from %lli to %lld, which means the string now has to be decimal, instead

[libvirt] [PATCH 04/10] cgroup: Replace sscanf with virStrToLong_ll

2010-03-30 Thread Matthias Bolte
--- src/util/cgroup.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/util/cgroup.c b/src/util/cgroup.c index 496d9d3..4cb09b6 100644 --- a/src/util/cgroup.c +++ b/src/util/cgroup.c @@ -12,7 +12,6 @@ #include stdio.h #include stdint.h -#include inttypes.h

Re: [libvirt] [PATCH 04/10] cgroup: Replace sscanf with virStrToLong_ll

2010-03-30 Thread Eric Blake
On 03/30/2010 10:20 AM, Matthias Bolte wrote: -if (sscanf(strval, % SCNi64, value) != 1) +if (virStrToLong_ll(strval, NULL, 10, value) 0) Oops. You effectively changed from %lli to %lld, which means the string now has to be decimal, instead of octal or hex. Did you mean to pass 0 as