Re: [libvirt] [PATCH 04/14] Centralize error reporting for URI parsing/formatting problems

2012-03-23 Thread Daniel P. Berrange
On Thu, Mar 22, 2012 at 12:03:11PM +0800, Osier Yang wrote: On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com @@ -70,8 +84,7 @@ virURIFormat(virURIPtr uri) char *ret; /* First check: does it make sense to do anything */ -if (uri !=

Re: [libvirt] [PATCH 04/14] Centralize error reporting for URI parsing/formatting problems

2012-03-21 Thread Osier Yang
On 2012年03月21日 01:33, Daniel P. Berrange wrote: From: Daniel P. Berrangeberra...@redhat.com Move error reporting out of the callers, into virURIParse and virURIFormat, to get consistency. * include/libvirt/virterror.h, src/util/virterror.c: Add VIR_FROM_URI * src/util/viruri.c,

[libvirt] [PATCH 04/14] Centralize error reporting for URI parsing/formatting problems

2012-03-20 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Move error reporting out of the callers, into virURIParse and virURIFormat, to get consistency. * include/libvirt/virterror.h, src/util/virterror.c: Add VIR_FROM_URI * src/util/viruri.c, src/util/viruri.h: Add error reporting * src/esx/esx_driver.c,