Re: [libvirt] [PATCH 04/15] conf: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStoragePoolDef

2019-02-08 Thread John Ferlan
[...] >> @@ -1590,14 +1590,12 @@ virStoragePoolObjLoad(virStoragePoolObjListPtr pools, >> _("Storage pool config filename '%s' does " >> "not match pool name '%s'"), >> path, def->name); >> -virStoragePoolDefFree(

Re: [libvirt] [PATCH 04/15] conf: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStoragePoolDef

2019-02-07 Thread Erik Skultety
On Wed, Feb 06, 2019 at 08:41:36AM -0500, John Ferlan wrote: > Let's make use of the auto __cleanup capabilities cleaning up any > now unnecessary goto paths. For virStoragePoolDefParseXML use the > @def/@ret similarly as other methods. For storagePoolDefineXML make > it clearer and use @objNewDef

[libvirt] [PATCH 04/15] conf: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStoragePoolDef

2019-02-06 Thread John Ferlan
Let's make use of the auto __cleanup capabilities cleaning up any now unnecessary goto paths. For virStoragePoolDefParseXML use the @def/@ret similarly as other methods. For storagePoolDefineXML make it clearer and use @objNewDef after adding @newDef to the object. Signed-off-by: John Ferlan ---