Re: [libvirt] [PATCH 04/18] util: storage: Remove obsolete argument virStorageFileGetMetadataInternal

2014-04-22 Thread Eric Blake
On 04/22/2014 02:42 PM, Eric Blake wrote: > On 04/20/2014 04:13 PM, Peter Krempa wrote: >> As we already pass the whole structure down the call path there's no >> need to return some stuff in a separate argument. Remove the argument >> and call tweakers to avoid breaking semantics. > > s/call twea

Re: [libvirt] [PATCH 04/18] util: storage: Remove obsolete argument virStorageFileGetMetadataInternal

2014-04-22 Thread Eric Blake
On 04/20/2014 04:13 PM, Peter Krempa wrote: > As we already pass the whole structure down the call path there's no > need to return some stuff in a separate argument. Remove the argument > and call tweakers to avoid breaking semantics. s/call tweakers/tweak callers/ > > virStorageFileGetMetadata

[libvirt] [PATCH 04/18] util: storage: Remove obsolete argument virStorageFileGetMetadataInternal

2014-04-20 Thread Peter Krempa
As we already pass the whole structure down the call path there's no need to return some stuff in a separate argument. Remove the argument and call tweakers to avoid breaking semantics. virStorageFileGetMetadataFromBuf will be refactored later along with the storage driver. --- src/util/virstorag