Re: [libvirt] [PATCH 05/10] tests: use virtTestDifferenceFull in tests where we have output file

2016-01-08 Thread Peter Krempa
On Thu, Jan 07, 2016 at 12:32:37 +0100, Pavel Hrdina wrote: > This will enable regenerate functionality for those tests to make > developer lives easier while updating tests. > > Signed-off-by: Pavel Hrdina > --- > tests/domainsnapshotxml2xmltest.c | 2 +- >

Re: [libvirt] [PATCH 05/10] tests: use virtTestDifferenceFull in tests where we have output file

2016-01-08 Thread Cole Robinson
On 01/08/2016 08:21 AM, Peter Krempa wrote: >> >> if (STRNEQ(expectxml, actualxml)) { >> -virtTestDifference(stderr, expectxml, actualxml); >> +virtTestDifferenceFull(stderr, expectxml, xml, actualxml, NULL); >> goto fail; >> } >> > > I'm specially worried

Re: [libvirt] [PATCH 05/10] tests: use virtTestDifferenceFull in tests where we have output file

2016-01-08 Thread Daniel P. Berrange
On Fri, Jan 08, 2016 at 11:19:04AM -0500, Cole Robinson wrote: > On 01/08/2016 08:21 AM, Peter Krempa wrote: > >> > >> if (STRNEQ(expectxml, actualxml)) { > >> -virtTestDifference(stderr, expectxml, actualxml); > >> +virtTestDifferenceFull(stderr, expectxml, xml, actualxml,

[libvirt] [PATCH 05/10] tests: use virtTestDifferenceFull in tests where we have output file

2016-01-07 Thread Pavel Hrdina
This will enable regenerate functionality for those tests to make developer lives easier while updating tests. Signed-off-by: Pavel Hrdina --- tests/domainsnapshotxml2xmltest.c | 2 +- tests/interfacexml2xmltest.c | 2 +- tests/lxcconf2xmltest.c | 2 +-

[libvirt] [PATCH 05/10] tests: use virtTestDifferenceFull in tests where we have output file

2015-12-10 Thread Pavel Hrdina
This will enable regenerate functionality for those tests to make developer lives easier while updating tests. Signed-off-by: Pavel Hrdina --- tests/domainsnapshotxml2xmltest.c | 2 +- tests/interfacexml2xmltest.c | 2 +- tests/lxcconf2xmltest.c | 2 +-