Re: [libvirt] [PATCH 05/11] Convert Xen domain start/migration APIs to use virDomainDefPtr

2013-05-23 Thread John Ferlan
On 05/09/2013 08:59 AM, Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com [...snip...] diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c index 89b038c..8b7dec9 100644 --- a/src/xen/xen_driver.c +++ b/src/xen/xen_driver.c @@ -1294,18 +1294,31 @@ static char *

Re: [libvirt] [PATCH 05/11] Convert Xen domain start/migration APIs to use virDomainDefPtr

2013-05-21 Thread Daniel P. Berrange
On Mon, May 20, 2013 at 11:40:34AM -0600, Jim Fehlig wrote: I finally have some time to continue reviewing this series... Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce use of a virDomainDefPtr in the domain migrate start APIs to simplify introduction

Re: [libvirt] [PATCH 05/11] Convert Xen domain start/migration APIs to use virDomainDefPtr

2013-05-20 Thread Jim Fehlig
I finally have some time to continue reviewing this series... Daniel P. Berrange wrote: From: Daniel P. Berrange berra...@redhat.com Introduce use of a virDomainDefPtr in the domain migrate start APIs to simplify introduction of ACL security checks. Not really the 'start' API, but

[libvirt] [PATCH 05/11] Convert Xen domain start/migration APIs to use virDomainDefPtr

2013-05-09 Thread Daniel P. Berrange
From: Daniel P. Berrange berra...@redhat.com Introduce use of a virDomainDefPtr in the domain migrate start APIs to simplify introduction of ACL security checks. The virDomainPtr cannot be safely used, since the app may have supplied mis-matching name/uuid/id fields. eg the name points to domain