Re: [libvirt] [PATCH 05/13] util: storage: Drop pointless 'enabled' form PR definition

2018-05-14 Thread John Ferlan
On 05/14/2018 06:41 AM, Peter Krempa wrote: > Everything can be disabled by not using the parent element. There's no > need to store this explicitly. Additionally it does not add any value > since any configuration is dropped if enabled='no' is configured. > > Drop the attribute and adjust the

Re: [libvirt] [PATCH 05/13] util: storage: Drop pointless 'enabled' form PR definition

2018-05-14 Thread John Ferlan
On 05/14/2018 06:41 AM, Peter Krempa wrote: > Everything can be disabled by not using the parent element. There's no > need to store this explicitly. Additionally it does not add any value > since any configuration is dropped if enabled='no' is configured. > > Drop the attribute and adjust the

Re: [libvirt] [PATCH 05/13] util: storage: Drop pointless 'enabled' form PR definition

2018-05-14 Thread Michal Privoznik
On 05/14/2018 12:41 PM, Peter Krempa wrote: > Everything can be disabled by not using the parent element. There's no > need to store this explicitly. Additionally it does not add any value > since any configuration is dropped if enabled='no' is configured. > > Drop the attribute and adjust the

[libvirt] [PATCH 05/13] util: storage: Drop pointless 'enabled' form PR definition

2018-05-14 Thread Peter Krempa
Everything can be disabled by not using the parent element. There's no need to store this explicitly. Additionally it does not add any value since any configuration is dropped if enabled='no' is configured. Drop the attribute and adjust the code accordingly.t Signed-off-by: Peter Krempa