Re: [libvirt] [PATCH 05/14] conf: Introduce VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE

2017-11-16 Thread Andrea Bolognani
On Thu, 2017-11-16 at 14:08 +0100, Pavel Hrdina wrote: > On Thu, Nov 16, 2017 at 02:00:24PM +0100, Andrea Bolognani wrote: > > On Thu, 2017-11-16 at 12:30 +0100, Pavel Hrdina wrote: > > > > @@ -9143,6 +9143,14 @@ qemuChrIsPlatformDevice(const virDomainDef *def, > > > > return true; >

Re: [libvirt] [PATCH 05/14] conf: Introduce VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE

2017-11-16 Thread Pavel Hrdina
On Thu, Nov 16, 2017 at 02:00:24PM +0100, Andrea Bolognani wrote: > On Thu, 2017-11-16 at 12:30 +0100, Pavel Hrdina wrote: > > > @@ -9143,6 +9143,14 @@ qemuChrIsPlatformDevice(const virDomainDef *def, > > > return true; > > > } > > > > > > +/* If we got all the way here and

Re: [libvirt] [PATCH 05/14] conf: Introduce VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE

2017-11-16 Thread Andrea Bolognani
On Thu, 2017-11-16 at 12:30 +0100, Pavel Hrdina wrote: > > @@ -9143,6 +9143,14 @@ qemuChrIsPlatformDevice(const virDomainDef *def, > > return true; > > } > > > > +/* If we got all the way here and we're still stuck with the default > > + * target type for a serial

Re: [libvirt] [PATCH 05/14] conf: Introduce VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE

2017-11-16 Thread Pavel Hrdina
On Wed, Nov 15, 2017 at 12:50:08PM +0100, Andrea Bolognani wrote: > This is the first step in getting rid of the assumption that > isa-serial is the default target type for serial devices. > > Signed-off-by: Andrea Bolognani > --- > src/conf/domain_conf.c | 8

[libvirt] [PATCH 05/14] conf: Introduce VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_NONE

2017-11-15 Thread Andrea Bolognani
This is the first step in getting rid of the assumption that isa-serial is the default target type for serial devices. Signed-off-by: Andrea Bolognani --- src/conf/domain_conf.c | 8 +--- src/conf/domain_conf.h | 3 ++- src/qemu/qemu_command.c|