Re: [libvirt] [PATCH 05/14] driver: fix handling of error return from finding resource

2018-04-24 Thread Michal Privoznik
On 04/19/2018 07:09 PM, Daniel P. Berrangé wrote: > The virFileFindResource method merely builds up the expected fully > qualified path to the resource. It does not actually check if it exists > on disk. The loadable module callers were mistakenly thinking a NULL > indicates the file doesn't exist

[libvirt] [PATCH 05/14] driver: fix handling of error return from finding resource

2018-04-19 Thread Daniel P . Berrangé
The virFileFindResource method merely builds up the expected fully qualified path to the resource. It does not actually check if it exists on disk. The loadable module callers were mistakenly thinking a NULL indicates the file doesn't exist on disk, whereas it in fact indicates an out of memory