Re: [libvirt] [PATCH 05/16] snapshot: Drop virDomainSnapshotDef.current

2019-03-21 Thread Eric Blake
On 3/20/19 12:40 AM, Eric Blake wrote: > The only use for the 'current' member of virDomainSnapshotDef was with > the PARSE/FORMAT_INTERNAL flag for controlling an internal-use > element marking whether a particular snapshot definition was > current, and even then, only by the qemu driver on outpu

Re: [libvirt] [PATCH 05/16] snapshot: Drop virDomainSnapshotDef.current

2019-03-21 Thread Eric Blake
On 3/20/19 2:57 PM, John Ferlan wrote: > > > On 3/20/19 1:40 AM, Eric Blake wrote: >> The only use for the 'current' member of virDomainSnapshotDef was with >> the PARSE/FORMAT_INTERNAL flag for controlling an internal-use >> element marking whether a particular snapshot definition was >> curren

Re: [libvirt] [PATCH 05/16] snapshot: Drop virDomainSnapshotDef.current

2019-03-20 Thread John Ferlan
On 3/20/19 1:40 AM, Eric Blake wrote: > The only use for the 'current' member of virDomainSnapshotDef was with > the PARSE/FORMAT_INTERNAL flag for controlling an internal-use > element marking whether a particular snapshot definition was > current, and even then, only by the qemu driver on out

[libvirt] [PATCH 05/16] snapshot: Drop virDomainSnapshotDef.current

2019-03-19 Thread Eric Blake
The only use for the 'current' member of virDomainSnapshotDef was with the PARSE/FORMAT_INTERNAL flag for controlling an internal-use element marking whether a particular snapshot definition was current, and even then, only by the qemu driver on output, and by qemu and test driver on input. But th