Re: [libvirt] [PATCH 05/21] qemu_hotplug: eliminate multiple identical qemuDomainDetachHost*Device() functions

2019-03-22 Thread Laine Stump
On 3/22/19 8:28 AM, Ján Tomko wrote: On Thu, Mar 21, 2019 at 06:28:45PM -0400, Laine Stump wrote: There are separate Detach functions for PCI, USB, SCSI, Vhost, and Mediated hostdevs, but the functions are all 100% the same code, except that the PCI function checks for the guest side of the

Re: [libvirt] [PATCH 05/21] qemu_hotplug: eliminate multiple identical qemuDomainDetachHost*Device() functions

2019-03-22 Thread Laine Stump
On 3/22/19 4:27 AM, Peter Krempa wrote: On Thu, Mar 21, 2019 at 18:28:45 -0400, Laine Stump wrote: There are separate Detach functions for PCI, USB, SCSI, Vhost, and Mediated hostdevs, but the functions are all 100% the same code, except that the PCI function checks for the guest side of the

Re: [libvirt] [PATCH 05/21] qemu_hotplug: eliminate multiple identical qemuDomainDetachHost*Device() functions

2019-03-22 Thread Ján Tomko
On Thu, Mar 21, 2019 at 06:28:45PM -0400, Laine Stump wrote: There are separate Detach functions for PCI, USB, SCSI, Vhost, and Mediated hostdevs, but the functions are all 100% the same code, except that the PCI function checks for the guest side of the device being a PCI Multifunction device,

Re: [libvirt] [PATCH 05/21] qemu_hotplug: eliminate multiple identical qemuDomainDetachHost*Device() functions

2019-03-22 Thread Peter Krempa
On Thu, Mar 21, 2019 at 18:28:45 -0400, Laine Stump wrote: > There are separate Detach functions for PCI, USB, SCSI, Vhost, and > Mediated hostdevs, but the functions are all 100% the same code, > except that the PCI function checks for the guest side of the device > being a PCI Multifunction

[libvirt] [PATCH 05/21] qemu_hotplug: eliminate multiple identical qemuDomainDetachHost*Device() functions

2019-03-21 Thread Laine Stump
There are separate Detach functions for PCI, USB, SCSI, Vhost, and Mediated hostdevs, but the functions are all 100% the same code, except that the PCI function checks for the guest side of the device being a PCI Multifunction device, while the other 4 check that the device's alias != NULL. The