Re: [libvirt] [PATCH 05/22] esx_vi_generator: Simplify generate_helper_source

2018-03-19 Thread Radostin Stoyanov
On 19/03/18 10:42, Daniel P. Berrangé wrote: > On Sat, Mar 17, 2018 at 02:23:23PM +, Radostin Stoyanov wrote: >> The generate_helper_source() function returns a formatted string. >> This could be achieved without the use of a local variable "source" >> and string concatenation. >> >>

Re: [libvirt] [PATCH 05/22] esx_vi_generator: Simplify generate_helper_source

2018-03-19 Thread Daniel P . Berrangé
On Sat, Mar 17, 2018 at 02:23:23PM +, Radostin Stoyanov wrote: > The generate_helper_source() function returns a formatted string. > This could be achieved without the use of a local variable "source" > and string concatenation. > > Signed-off-by: Radostin Stoyanov >

[libvirt] [PATCH 05/22] esx_vi_generator: Simplify generate_helper_source

2018-03-17 Thread Radostin Stoyanov
The generate_helper_source() function returns a formatted string. This could be achieved without the use of a local variable "source" and string concatenation. Signed-off-by: Radostin Stoyanov --- src/esx/esx_vi_generator.py | 29 ++--- 1 file